Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search counts behave the same as listing counts #252

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

recalcitrantsupplant
Copy link
Collaborator

Search result counts are now consistent with listing counts:

If limit of 20 is requested:

  • a search with limit N+1 = 21 is performed
    • if the results count = 21, then ">20" is returned,
    • otherwise the result count is returned as a string (e.g. 14 results returns "14")

Separately, the default search limit has been set to 10, and is configurable via "search_count_limit" on the app settings.

…with the number of results or if at the limit=n+1 then ">n" as a string
…fy them in test. Fix checking of result count to be against the SearchQueryRegex limit in order to account for both QSA and default limits.
Copy link
Collaborator

@lalewis1 lalewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep all looks good.

@recalcitrantsupplant recalcitrantsupplant merged commit f9e4152 into main Aug 16, 2024
1 check passed
@recalcitrantsupplant recalcitrantsupplant deleted the david/fix-search-count branch August 16, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants